Display user email for administrators #1808
Conversation
| @@ -128,6 +138,7 @@ export default { | |||
| id | |||
| name | |||
| slug | |||
There was a problem hiding this comment.
At the moment, the backend does not allow anybody except the owner to see the email of the user. You will need to change permissions in the backend.
I think I would still feel safe, if only the owner or an admin user can see the email.
There was a problem hiding this comment.
Done, thanks @roschaefer
- Refactor all tests on permissionsMiddleware
aonomike
changed the title
There was a problem hiding this comment.
To me, this looks good and I can't see why we should not merge it. It's tested and there is nothing that comes to my mind, which we need to do before merging. Great job @aonomike !
But I'm a little hesitant to merge this before our daily standup. We could hear back from the others if we missed anything important here. it's a matter of security/data-privacy after all 馃槈
| ).resolves.toMatchObject({ | ||
| errors: [{ message: 'Not Authorised!' }], | ||
| data: { User: [null] }, | ||
| }) |
There was a problem hiding this comment.
This is so much better 馃槏
| @@ -33,6 +33,11 @@ | |||
| <b>{{ scope.row.name | truncate(20) }}</b> | |||
| </nuxt-link> | |||
| </template> | |||
| <template slot="email" slot-scope="scope"> | |||
| <a :href="`mailto:${scope.row.email}`"> | |||
| <b>{{ scope.row.email }}</b> | |||
There was a problem hiding this comment.
Some of those emails are quite long. Maybe we should think about how to fit the data into the layout? E.g. at some places in the app, we use | truncate(20) filter.
Although I'm OK to merge this and wait for our admins to complain about it 馃槈
There was a problem hiding this comment.
That's what I thought as well, @datenbrei mentioned that they might be copying and pasting the links, so maybe it's more difficult if it's truncated??
There was a problem hiding this comment.
Thanks @mattwr18 @roschaefer
Let me know if I need to update this :D
馃嵃 Pullrequest
Issues
fixes #1704
Images