Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: deploy script with new naming convention #2930

Merged
merged 1 commit into from Jan 31, 2020
Merged

fix: deploy script with new naming convention #2930

merged 1 commit into from Jan 31, 2020

Conversation

mattwr18
Copy link
Member

@mattwr18 mattwr18 changed the title Fix deploy script with new naming convention fix: deploy script with new naming convention Jan 30, 2020
@cypress
Copy link

cypress bot commented Jan 30, 2020 •
edited


Test summary

58 • 0 • 0 • 0

Run details
Project Human-Connection
Status Passed
Commit 87b58bc
Started Jan 30, 2020 1:00 PM
Ended Jan 30, 2020 1:16 PM
Duration 16:04 💡
OS Linux Ubuntu Linux - 16.04
Browser Electron 78

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

roschaefer
roschaefer approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@roschaefer roschaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me that's fine. 👍 Although I don't know why we have those prefixes.

@mattwr18 mattwr18 merged commit 6a60c56 into master Jan 31, 2020
@mattwr18 mattwr18 deleted the 2929-fix-deploy-script branch January 31, 2020 13:46
@mattwr18
Copy link
Member Author

we have those prefixes @roschaefer because you added them with the Helm chart
{{ .Release.Name }}, I chose develop for the develop server, and will choose staging for staging and production for the production server.

I really like this cause it means that someone can't accidentally delete a resource because of generic naming, ie kubectl delete deployment neo4j -n human-connection when using one context and thinking you are using another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roschaefer roschaefer roschaefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Master build broken in deploy step
2 participants
@mattwr18 @roschaefer