Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Node v13 compatbility #3041

Merged
merged 1 commit into from Feb 12, 2020
Merged

build(deps): Node v13 compatbility #3041

merged 1 commit into from Feb 12, 2020

Conversation

roschaefer
Copy link
Contributor

🍰 Pullrequest

Force update of fs-capacitor, see jaydenseric/graphql-upload#170 (comment)

Issues

I am testing file uploads on my machine. My local node has version v13.7.0. This resolution fix does the trick for me.

@roschaefer roschaefer self-assigned this Feb 11, 2020
@mattwr18
Copy link
Member

I tried this, and it didn't seem to work for me, but I can test it again @roschaefer

@cypress
Copy link

cypress bot commented Feb 11, 2020



Test summary

61 0 0 0


Run details

Project Human-Connection
Status Passed
Commit 68031ba
Started Feb 11, 2020 10:40 PM
Ended Feb 11, 2020 10:56 PM
Duration 16:22 💡
OS Linux Ubuntu Linux - 16.04
Browser Electron 78

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@mattwr18 mattwr18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'm ok with this, although I would love it if apollos-server-core would upgrade their fs-capacitor

@mattwr18 mattwr18 merged commit b4fe3de into master Feb 12, 2020
@mattwr18 mattwr18 deleted the node_v13_compatiblity branch February 12, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants