Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [wip] migrate legacy embed markup [3395] #3470

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

rbeer
Copy link
Contributor

@rbeer rbeer commented Apr 12, 2020

🍰 Pullrequest

Adds migrattion to update posts with embeds to new block level style markup; the transformation ensures paragraphs around embeds.

<p><a href=\"https://youtu.be/jB6mI8uVxKU\" class=\"embed\" target=\"_blank\"></a></p>

to

<p></p><a href=\"https://youtu.be/jB6mI8uVxKU\" class=\"embed\" target=\"_blank\"></a><p></p>

Issues

Todo

  • Write migration

  updateEmbeds.transform takes a HTML markup
  string - i.e. content of the editor,
  saved in DB - and transforms inline type embeds
  to block type embeds

  ```js
  import { transform } from './updateEmbeds'
  const legacyEmbedMarkup = '...'
  const newEmbedMarkup = transform(legacyEmbedMarkup)
  ```
@cypress
Copy link

cypress bot commented Apr 12, 2020



Test summary

65 1 0 0


Run details

Project Human-Connection
Status Failed
Commit bff91b0
Started Apr 16, 2020 1:45 PM
Ended Apr 16, 2020 2:06 PM
Duration 20:17 💡
OS Linux Ubuntu Linux - 16.04
Browser Firefox 68

View run in Cypress Dashboard ➡️


Failures

cypress/integration/notifications/Mentions.feature Failed
1 Notification for a mention > Mention another user, re-login as this user and see notifications

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Apr 13, 2020



Test summary

66 0 0 0


Run details

Project Human-Connection
Status Passed
Commit 816e58f ℹ️
Started Apr 16, 2020 1:45 PM
Ended Apr 16, 2020 2:05 PM
Duration 19:29 💡
OS Linux Ubuntu Linux - 16.04
Browser Firefox 68

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@stale
Copy link

stale bot commented Jun 15, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant