Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [WIP] 🍰 Editor List Styles [3492] #3493

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rbeer
Copy link
Contributor

@rbeer rbeer commented Apr 21, 2020

🍰 Pullrequest

Adds decorators back to <ul>, <ol> Elements, inside Editor.
Using the logo as bullet is maybe a bit over the top ☺️

list_decorators

list_decorators_content

Issues

@rbeer rbeer marked this pull request as draft April 21, 2020 00:28
@cypress
Copy link

cypress bot commented Apr 21, 2020



Test summary

66 0 0 0


Run details

Project Human-Connection
Status Passed
Commit 408b939 ℹ️
Started Apr 21, 2020 2:54 AM
Ended Apr 21, 2020 3:16 AM
Duration 21:42 💡
OS Linux Ubuntu Linux - 16.04
Browser Firefox 68

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Apr 21, 2020



Test summary

66 0 0 0


Run details

Project Human-Connection
Status Passed
Commit a8ec2f5
Started Apr 21, 2020 1:12 PM
Ended Apr 21, 2020 1:36 PM
Duration 23:42 💡
OS Linux Ubuntu Linux - 16.04
Browser Firefox 68

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@rbeer rbeer marked this pull request as ready for review April 22, 2020 13:05
@rbeer rbeer requested a review from Tirokk April 22, 2020 13:05
@Tirokk Tirokk changed the title fix: editor list styles [3492] fix: [WIP] 🍰 Editor List Styles [3492] Apr 23, 2020
Copy link
Member

@Tirokk Tirokk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rbeer ,

great that you care for this. Very important! 💫

The code looks good and nice as far I can see.

About the functionality I have stated some comments in the both following pictures:

Bildschirmfoto 2020-04-23 um 14 39 11

Bildschirmfoto 2020-04-23 um 14 48 37

Only just in case you could do something about it … 🤗🙏🏼

@Tirokk
Copy link
Member

Tirokk commented May 27, 2020

Hey @rbeer ,
do you have time to care for this issue or PR? 🤗💫
Greetings

@Tirokk Tirokk added this to 2 - To do - high priority in Roadmap Menschheitsfamilie Aug 3, 2020
@sushidave
Copy link

@rbeer @Tirokk Great if this could be impemented by the next release together with the PR for the margin issue #3628.
@rbeer If you don't have time for this now we could ask the contributor of the margin issue to take over. Please advise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Roadmap
  
Awaiting triage
Roadmap Menschheitsfamilie
  
2 - To develop - high priority
Development

Successfully merging this pull request may close these issues.

🐛 [Bug] Lists in posts and comments are not displayed as lists
3 participants