[WIP] Frontend implementation for notifications #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roschaefer
force-pushed
the
347-display_notifications
branch
from
8030ed3
to
5b77c92
Compare
Cypress tests don't need to be executed in order so we don't need the numbers anymore. cc @appinteractive
* add notification in seeds * extremely odd styling - on the index page the notification looks OK, on the post page, the post card elements appear more densely packed
|
on the root path |
… into 347-display_notifications
ulfgebhardt
approved these changes
Apr 10, 2019
Note that we don't create duplicate notifications. I made use of the behaviour of XSS-middleware: It removes all css classes from `<a>` anchors. Because notifications rely on a css class `mention` which gets removed in a later middleware, this gives us a nice behaviour for re-notifications without creating duplicates. The downside is that it creates dependencies between middlewares and it's not that obvious at all. cc @mattwr18 @ulfgebhardt @appinteractive @Tirokk
This will help some people not to loose data after accidently clicking on the user @-mentioning.
Bumps [tiptap-extensions](https://github.com/scrumpy/tiptap) from 1.14.0 to 1.15.0. - [Release notes](https://github.com/scrumpy/tiptap/releases) - [Commits](https://github.com/scrumpy/tiptap/compare/tiptap-extensions@1.14.0...tiptap-extensions@1.15.0) Signed-off-by: dependabot[bot] <support@dependabot.com>
Fixed a bug along the way `(post.contentExcerpt == null)`
cc @mattwr18 Please don't see this as a revert of your work. Your structure of the `notification-post-card` component was helpful and showed the redundancy with `hc-post-card`. I reused a lot of the code, but because I merged both components it now *looks* as if I authored all the code.
Unfortunately with `v-html` you cannot use filters directly in handlebars. See: nuxt/nuxt#231 I also fixed the tests even **without** mocking vue-filters.js plugin 👍
…on/Human-Connection into 347-display_notifications
roschaefer
changed the title
roschaefer
force-pushed
the
347-display_notifications
branch
2 times, most recently
from
40c7578
to
57a53a4
Compare
cc @mattwr18 @Tirokk @ulfgebhardt @appinteractive The factories don't use string interpolation now but they use variables. This resolves some errors of escaping strings when you send html along with `post.content`. It is much cleaner, too.
Sometimes, the popup was covering the create-post button thus failing some cypress tests locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pullrequest
Issues
Checklist
How2Test
Todo
PostCard.vueinNotification.vue?