Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display access permissions for models on model detailed view #192

Closed
appukuttan-shailesh opened this issue May 7, 2018 · 8 comments
Closed

Comments

@appukuttan-shailesh
Copy link
Collaborator

appukuttan-shailesh commented May 7, 2018

Partly related to #191

As a user cannot edit/update all the models that they see in the model catalog, it would be useful to have icons (maybe inside a "Permissions" box?) that indicate whether a user has only READ permissions for that specific model, or both READ and WRITE.

Often it is not easy to identify why you don't see the "EDIT" options for some of the models. Also, you cannot run a test on any model that you see in the model catalog. You need to have WRITE permissions for these models.

For APIs,
READ = GET
WRITE = PUT/POST

@apdavison : Go ahead with this?

@apdavison
Copy link
Member

Why do you need write permission to run a test on a model?

@appukuttan-shailesh
Copy link
Collaborator Author

To be more accurate... running the test does not require write, but to register the new results (POST) we require write permission.

@apdavison
Copy link
Member

Why?

@appukuttan-shailesh
Copy link
Collaborator Author

If the model is public but the user is not a member of the model's host Collab. The user can see the model in the model catalog, but cannot PUT/POST.

See table here: http://hbp-validation-client.readthedocs.io/en/master/#general-info

@appukuttan-shailesh
Copy link
Collaborator Author

This is as per the current implementation. Found an example of this last week.

@apdavison
Copy link
Member

No permissions should be required to post test results (the user just needs an HBP account).

If there are related data, then the user should specify a collab for which he/she has permission to write to the storage.

Even if writing to storage fails, however, the result should still be registered.

@apdavison
Copy link
Member

On the topic of the issue, I agree it would be useful to display a small box that explains the permissions.

@appukuttan-shailesh
Copy link
Collaborator Author

This continues to be a problem... should we take this up on priority?

HFragnaud added a commit to HFragnaud/hbp-validation-framework_dev that referenced this issue May 16, 2018
HFragnaud added a commit that referenced this issue May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants