-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: erroneous implementation of reading RGB nifti #23
Conversation
tests: added tests for arbitary dimension rgb nii tests: added testing values before and after volume_file_to_precomputed previous implementation of reading rgb nii was errorneous.
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
+ Coverage 92.40% 92.43% +0.02%
==========================================
Files 25 25
Lines 1475 1480 +5
Branches 211 230 +19
==========================================
+ Hits 1363 1368 +5
Misses 63 63
Partials 49 49
Continue to review full report at Codecov.
|
Apologies for the spam. I noticed that there (still) were some error in the code (turns out, the byte order matters very much how The PR should be ready for review now. |
Apologies. There are still some issues that I am trying to sort out re this PR. I will mark ready for review & tag you when it's ready. |
test: test nibabel.load proxy
Hi @xgui3783, what is the status of this PR? Is it still relevant? If so, do you see any chance to get it ready before we release version 1.1.0? |
@ylep , sorry, still relevant, but no progress. It was brought to me attention that, since there are no unanimous format on how rgb is encoded in nifti, different softwares seems to use their own system to encode the rgb channel. Perhaps I could close thie PR and add an issue instead. |
bugfix: rgb nifti bug
tests: added tests for arbitary dimension rgb nii
tests: added testing values before and after volume_file_to_precomputed
previous implementation of reading rgb nii was errorneous.