use urlparse to generate url safe file names (#295)

HumanCellAtlas · Apr 11, 2019 · 9d910a3 · kislyuk · Apr 16, 2019 · sampierson
1 parent e38364b
commit 9d910a3
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/hca/upload/api_client.py b/hca/upload/api_client.py
@@ -1,4 +1,8 @@
 import json
+try:
+    import urllib.parse as urlparse
+except ImportError:
+    import urllib as urlparse
 
 import requests
 from tenacity import retry, stop_after_attempt, wait_fixed
@@ -35,9 +39,10 @@ def credentials(self, area_uuid):
 
     @retry(reraise=True, wait=wait_fixed(2), stop=stop_after_attempt(3))
     def file_upload_notification(self, area_uuid, filename):
+        url_safe_filename = urlparse.quote(filename)
         url = "{api_url_base}/area/{area_uuid}/{filename}".format(api_url_base=self.api_url_base,
                                                                   area_uuid=area_uuid,
-                                                                  filename=filename)
+                                                                  filename=url_safe_filename)
         response = requests.post(url)
         if not response.status_code == requests.codes.accepted:
             raise RuntimeError(