Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing max ischemic_time value #89

Closed
malloryfreeberg opened this issue Dec 5, 2017 · 1 comment
Closed

Increasing max ischemic_time value #89

malloryfreeberg opened this issue Dec 5, 2017 · 1 comment

Comments

@malloryfreeberg
Copy link
Member

We have data from a group specifically interested in looking at cells up to 72h ischemia. Converted to seconds this is 259200 seconds, which doesn't validate against the current maximum level set for the ischemic_time field (100000 seconds).

        "ischemic_time": {
            "minimum": 0, 
            "type": "integer", 
            "description": "Duration of time, in seconds, that the body part had insufficient blood supply.", 
            "maximum": 100000
        }, 

What was the motivation behind choosing this maximum value? I suggest increasing to accommodate this use case.

I'm happy to make the change, which will then necessitate a minor release v4.3.0.

@dosumis
Copy link
Contributor

dosumis commented Dec 5, 2017

I'd increase. I guess the original value was added because experiments to look at degredation of sample due to ischemia were not anticipated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants