New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Installation Instructions #760
Conversation
95c5836
to
c1ba6ac
Compare
Codecov Report
@@ Coverage Diff @@
## master #760 +/- ##
=======================================
Coverage 96.33% 96.33%
=======================================
Files 93 93
Lines 8789 8789
=======================================
Hits 8467 8467
Misses 322 322 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend changing "M1 macs" to "ARM64 macs" (so that people know it also applies to M2 macs, and future ones with the same architecture). Otherwise looks good to me!
* Fix broken link in the experts documentation. * Update installation instructions with workarounds for broken dependencies. * Target all ARM64 macs not just M1 ones in the installation instructions.
Description
Due to a bug in gym we need specific setuptools an pip version to install
imitation
. Also on M1 Macs we need a workaround to installgrpio
which also is a dependency ofimitation
.This PR documents both of this in the installation instructions so people do not keep running into the same issues when installing
imitation
.You find the rendered instructions here.
Testing
Documentation only changes.