Fix MacOS Pipeline: Include tests not in subdirectories #797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
The Mac CI is red but this is because notebook tests that were previously being skipped are in fact failing. At least some of the notebook tests seem cross-platform, so I suggest we review this PR first and consider merging it to get the CI functional, then address fixing the issues the now-functional CI is picking up in separate PRs. |
|
Only tests failing are related to 8a_train_sqil_sac, so merging -- these should get fixed in #800 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the MacOS pipeline was only running in tests that were in subdirectories of
tests/. This is because the glob was not quoted, so was being expanded by the shell (which did not properly parse**) rather than the CircleCI scriptTesting
Before: https://app.circleci.com/pipelines/github/HumanCompatibleAI/imitation/3888/workflows/a8c06177-af9f-4ec2-9bba-2e384f3d35c3/jobs/15718/parallel-runs/0/steps/0-109 -- observe all tests are in subdirectories
After: https://app.circleci.com/pipelines/github/HumanCompatibleAI/imitation/3925/workflows/88a81adc-aa48-4f1f-86cb-d8833171316a/jobs/15952/parallel-runs/0/steps/0-109 -- observe tests include those directly in tests such as
tests/test_examples.py