Adding ParallelSkillSet & tests #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaced import statements to remove unused imports. - Removed unused classes and variables. - Updated select_skill_to_improve to use a lower accuracy threshold. - Added documentation for ParallelSkillSet to explain its purpose.
and update predictions
|
Thank you for the great PR! Especially for tests ;-) |
niklub
requested changes
Nov 10, 2023
adala/skills/skillset.py
Outdated
| sequentially for complex problem decompositions and causal reasoning. In the most generic | ||
| cases, task decomposition can involve a graph-based approach. | ||
|
|
||
| Attributes: | ||
| skills (Dict[str, BaseSkill]): A dictionary of skills in the skill set. | ||
| """ | ||
|
|
There was a problem hiding this comment.
could you please remove these non-functional changes? it would be simpler to merge conflicts in this case. Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing
ParallelSkillSetclass - designed to represent a collection of skills that can be developed and applied simultaneously, as opposed to the sequential approach taken by the existingLinearSkillSet.This pull request includes basic unit tests for the
ParallelSkillSetclass to ensure its functionality aligns with expected behavior.Thanks Adala team for releasing such an exciting new library!!