Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: LSDV-5560: Fix plus and minus hotkeys #1561

Merged
merged 6 commits into from
Sep 28, 2023
Merged

Conversation

Gondragos
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

ctrl+plus and ctrl-minus hotkeys do not work for zoom in Image Segmentation.

What does this fix?

It adds aliases for plus and minus comands to make it work with original keymaster.

What libraries were added/updated?

@heartexlabs/ls-test

Does this change affect performance?

Nope

Does this change affect security?

Nope

What alternative approaches were there?

Forking and changing keymaster

What feature flags were used to cover this change?

N/A

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Hotkeys, Image Tools

src/core/Hotkey.ts Outdated Show resolved Hide resolved
src/core/Hotkey.ts Outdated Show resolved Hide resolved
tests/functional/yarn.lock Outdated Show resolved Hide resolved
Gondragos and others added 4 commits September 25, 2023 22:06
Co-authored-by: hlomzik <hlomzik@gmail.com>
Co-authored-by: hlomzik <hlomzik@gmail.com>
# Conflicts:
#	tests/functional/package.json
#	tests/functional/yarn.lock
@hlomzik hlomzik merged commit d34cf03 into master Sep 28, 2023
15 checks passed
@hlomzik hlomzik deleted the fb-lsdv-5560/zoom-hotkeys branch September 28, 2023 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants