Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: LEAP-256: Include the 'legacy' property in the 'Taxonomy' tag #1583

Merged
merged 3 commits into from
Oct 19, 2023

Conversation

juliosgarbi
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

A lot of things was changed in New Taxonomy, so some slight regression is possible in some cases, so some clients may want to use the old one.

What does this fix?

Include the 'legacy' property in the 'Taxonomy' tag, allowing users to access the legacy version, even when the feature flag is enabled.

What libraries were added/updated?

no

Does this change affect performance?

no

Does this change affect security?

no

What alternative approaches were there?

no

What feature flags were used to cover this change?

fflag_feat_front_lsdv_5451_async_taxonomy_110823_short

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

@github-actions github-actions bot added the fix label Oct 10, 2023
@juliosgarbi
Copy link
Contributor Author

juliosgarbi commented Oct 19, 2023

/git merge master

Successfully pushed new changes:
Merge remote-tracking branch 'origin/master' into fb-leap-256 (c65ef75)

Workflow run

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
src/tags/control/Taxonomy/Taxonomy.js 72.44% <100.00%> (+0.10%) ⬆️

📢 Thoughts on this report? Let us know!.

@juliosgarbi juliosgarbi merged commit ce5217c into master Oct 19, 2023
12 checks passed
@juliosgarbi juliosgarbi deleted the fb-leap-256 branch October 19, 2023 18:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants