Skip to content
This repository has been archived by the owner on Apr 18, 2024. It is now read-only.

fix: LEAP-364: Fix crosshair functionality #1616

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Conversation

Gondragos
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

The crosshair parameter was broken,

What libraries were added/updated?

ls-test

Does this change affect performance?

Nope

Does this change affect security?

Nope

What alternative approaches were there?

N/A

What feature flags were used to cover this change?

'fflag_fix_front_leap_32_zoom_perf_190923_short'

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Image

@codecov-commenter
Copy link

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/components/ImageView/ImageView.js 74.43% <0.00%> (-7.22%) ⬇️

... and 226 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@Gondragos Gondragos enabled auto-merge (squash) November 14, 2023 15:25
@Gondragos Gondragos merged commit 4891f39 into master Nov 14, 2023
11 of 12 checks passed
@Gondragos Gondragos deleted the fb-leap-364/fix-crosshair branch November 14, 2023 15:48
MasherJames pushed a commit to HelloPareto/label-studio-frontend that referenced this pull request Feb 29, 2024
* fix: LEAP-364: Fix crosshair functionality

* Update ls-test

* Add regerssion test

* Update ls-test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants