Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] bump pydantic version and fix unit tests #142

Merged
merged 2 commits into from
Aug 3, 2023
Merged

[fix] bump pydantic version and fix unit tests #142

merged 2 commits into from
Aug 3, 2023

Conversation

edwinzhng
Copy link
Contributor

  • This PR fixes Update requirements due to dependency conflict #139 by addressing issues related to the latest Pydantic 2.0 release (default values for the ClientCredentials model)
  • Loosen restrictions on Pydantic version to allow V2
  • Fixes client unit tests that were failing on main before

@hogepodge hogepodge requested a review from bmartel August 2, 2023 17:38
@hogepodge
Copy link

@edwinzhng I'll bring this to the team for review. Thanks!

@bmartel
Copy link
Contributor

bmartel commented Aug 2, 2023

@edwinzhng Can you rerun the linter locally against your changes, it is failing the lint step.

@lmmx lmmx mentioned this pull request Aug 3, 2023
Open
@edwinzhng
Copy link
Contributor Author

@edwinzhng Can you rerun the linter locally against your changes, it is failing the lint step.

Done!

@bmartel bmartel merged commit 0e3764d into HumanSignal:master Aug 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmartel bmartel bmartel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update requirements due to dependency conflict
3 participants
@edwinzhng @hogepodge @bmartel