-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LSDV-4711: CORS error accessing previously annotated data #3991
Conversation
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved - but please clear out the extra space - although its not a show stopper
Co-authored-by: yyassi-heartex <104568407+yyassi-heartex@users.noreply.github.com>
…if consumed or used directly
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #3991 +/- ##
===========================================
- Coverage 76.66% 76.63% -0.03%
===========================================
Files 155 155
Lines 11634 11668 +34
===========================================
+ Hits 8919 8942 +23
- Misses 2715 2726 +11 see 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
To enable Auto Merge for this PR also merge those PRs: |
…Signal#3991) * [submodules] Build static heartexlabs/label-studio-frontend * ci: Update Feature Flags * create a presign proxy for task uris which use cloud storage and presigned urls * ci: Update Feature Flags * [submodules] Build static heartexlabs/dm2 * ci: Update Feature Flags * [submodules] Build static heartexlabs/label-studio-frontend * [submodules] Build static heartexlabs/label-studio-frontend * [submodules] Build static heartexlabs/label-studio-frontend * [submodules] Build static heartexlabs/dm2 * update all_urls * Update label_studio/tasks/models.py Co-authored-by: yyassi-heartex <104568407+yyassi-heartex@users.noreply.github.com> * ensure url is including server hostname and can be directly accessed if consumed or used directly * add tests for presign changes * [submodules] Build static heartexlabs/label-studio-frontend * [submodules] Build static heartexlabs/dm2 * [submodules] Build static heartexlabs/label-studio-frontend --------- Co-authored-by: Brandon Martel <brandonmartel@gmail.com> Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com> Co-authored-by: yyassi-heartex <104568407+yyassi-heartex@users.noreply.github.com>
Hi @bmartel!
This PR was created in response to a PRs in upstream repo: