Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LSDV-4711: CORS error accessing previously annotated data #3991

Merged
merged 23 commits into from
Apr 24, 2023

Conversation

robot-ci-heartex
Copy link
Collaborator

@robot-ci-heartex robot-ci-heartex commented Apr 6, 2023

@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 18d3ea2
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/64469273a8b8af0008024d0a

@github-actions github-actions bot added the fix label Apr 6, 2023
@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 98c3b2b
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/642ed09df97f740008135398

@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 18d3ea2
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/644692735027d20008cd28f1

Copy link
Contributor

@yyassi-heartex yyassi-heartex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved - but please clear out the extra space - although its not a show stopper

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03 ⚠️

Comparison is base (9f9ae80) 76.66% compared to head (b307088) 76.63%.

❗ Current head b307088 differs from pull request most recent head 18d3ea2. Consider uploading reports for the commit 18d3ea2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3991      +/-   ##
===========================================
- Coverage    76.66%   76.63%   -0.03%     
===========================================
  Files          155      155              
  Lines        11634    11668      +34     
===========================================
+ Hits          8919     8942      +23     
- Misses        2715     2726      +11     

see 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@robot-ci-heartex
Copy link
Collaborator Author

To enable Auto Merge for this PR also merge those PRs:

@robot-ci-heartex robot-ci-heartex marked this pull request as ready for review April 24, 2023 14:30
@robot-ci-heartex robot-ci-heartex enabled auto-merge (squash) April 24, 2023 14:30
@robot-ci-heartex robot-ci-heartex merged commit c63ece1 into develop Apr 24, 2023
30 of 40 checks passed
label_studio/data_import/api.py Show resolved Hide resolved
label_studio/data_import/api.py Show resolved Hide resolved
label_studio/tasks/models.py Show resolved Hide resolved
label_studio/tasks/models.py Show resolved Hide resolved
@bmartel bmartel deleted the fb-lsdv-4711 branch April 24, 2023 18:34
shayantabatabaee pushed a commit to shayantabatabaee/label-studio that referenced this pull request Sep 19, 2023
…Signal#3991)

* [submodules] Build static heartexlabs/label-studio-frontend

* ci: Update Feature Flags

* create a presign proxy for task uris which use cloud storage and presigned urls

* ci: Update Feature Flags

* [submodules] Build static heartexlabs/dm2

* ci: Update Feature Flags

* [submodules] Build static heartexlabs/label-studio-frontend

* [submodules] Build static heartexlabs/label-studio-frontend

* [submodules] Build static heartexlabs/label-studio-frontend

* [submodules] Build static heartexlabs/dm2

* update all_urls

* Update label_studio/tasks/models.py

Co-authored-by: yyassi-heartex <104568407+yyassi-heartex@users.noreply.github.com>

* ensure url is including server hostname and can be directly accessed if consumed or used directly

* add tests for presign changes

* [submodules] Build static heartexlabs/label-studio-frontend

* [submodules] Build static heartexlabs/dm2

* [submodules] Build static heartexlabs/label-studio-frontend

---------

Co-authored-by: Brandon Martel <brandonmartel@gmail.com>
Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com>
Co-authored-by: yyassi-heartex <104568407+yyassi-heartex@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants