Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LSDV-4767: Use specific fields in api/projects/?ids= request #4039

Merged
merged 5 commits into from
Apr 25, 2023

Conversation

bmartel
Copy link
Contributor

@bmartel bmartel commented Apr 14, 2023

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Frontend

Describe the reason for change

To alleviate the amount of data requested in the projects' queries, adding a include= with only the data that is absolutely required when loading second pass data with query param ids=.

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Projects List

@netlify
Copy link

netlify bot commented Apr 14, 2023

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit fdb8af7
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/64401f80f81fa70007fa0eff

@netlify
Copy link

netlify bot commented Apr 14, 2023

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit fdb8af7
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/64401f80f81fa70007fa0efa

@github-actions github-actions bot added the fix label Apr 14, 2023
@bmartel
Copy link
Contributor Author

bmartel commented Apr 19, 2023

/frontend help

Command Description
/frontend build Get build frontend static for all repos
/frontend build lsf [sha] Get build frontend static for heartexlabs/label-studio-frontend only
/frontend build dm [sha] Get build frontend static for heartexlabs/dm2 only

@bmartel
Copy link
Contributor Author

bmartel commented Apr 19, 2023

/git help

Command Description
/git merge branch Merge branch branch into current branch

@bmartel
Copy link
Contributor Author

bmartel commented Apr 19, 2023

/git merge develop

Error: failed to execute "merge" command

Workflow run

@bmartel
Copy link
Contributor Author

bmartel commented Apr 19, 2023

/frontend build

Error: failed to get build

Workflow run

@bmartel bmartel enabled auto-merge (squash) April 19, 2023 17:12
@bmartel bmartel disabled auto-merge April 24, 2023 14:27
@bmartel bmartel marked this pull request as draft April 24, 2023 14:27
@bmartel bmartel marked this pull request as ready for review April 24, 2023 14:28
@bmartel bmartel merged commit 6fcded0 into develop Apr 25, 2023
25 checks passed
@bmartel bmartel deleted the fb-lsdv-4767 branch April 25, 2023 21:41
bmartel added a commit that referenced this pull request Apr 25, 2023
)

* fix: LSDV-4767: Use specific fields in api/projects/?ids= request

* ci: Build frontend

* ci: Build frontend

---------

Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com>
bmartel added a commit that referenced this pull request Apr 25, 2023
)

fix: LSDV-4767: Use specific fields in api/projects/?ids= request (#4039)

* fix: LSDV-4767: Use specific fields in api/projects/?ids= request

* ci: Build frontend

* ci: Build frontend

---------

Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com>
shayantabatabaee pushed a commit to shayantabatabaee/label-studio that referenced this pull request Sep 19, 2023
…manSignal#4039)

* fix: LSDV-4767: Use specific fields in api/projects/?ids= request

* ci: Build frontend

* ci: Build frontend

---------

Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants