feat: LSDV-5035: Use created_at from draft as the annotation draft_created_at #4259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #4259 +/- ##
===========================================
+ Coverage 75.74% 75.75% +0.01%
===========================================
Files 156 156
Lines 12075 12081 +6
===========================================
+ Hits 9146 9152 +6
Misses 2929 2929 ☔ View full report in Codecov by Sentry. |
bmartel
changed the title
triklozoid
approved these changes
May 29, 2023
vladimirheartex
approved these changes
May 30, 2023
bmartel
added a commit
that referenced
this pull request
May 30, 2023
…eated_at (#4259) * feat: LSDV-5035: Use created_at from draft as the annotation created_at * fix the update statement as it cannot be mass assigned and should not be open to this * save the draft created at to its own field to not disturb existing data * [submodules] Build static heartexlabs/dm2 * [submodules] Build static heartexlabs/dm2
bmartel
added a commit
that referenced
this pull request
May 30, 2023
* feat: LSDV-5035: Use created_at from draft as the annotation draft_created_at (#4259) * feat: LSDV-5035: Use created_at from draft as the annotation created_at * fix the update statement as it cannot be mass assigned and should not be open to this * save the draft created at to its own field to not disturb existing data * [submodules] Build static heartexlabs/dm2 * [submodules] Build static heartexlabs/dm2 * fix: LSDV-5163: Storage errors AttributeError can't set attribute 'storage' when pre-signed proxy urls are turned on (#4243) * fix: LSDV-5163: Storage errors AttributeError can't set attribute 'storage' when pre-signed proxy urls are turned on * removing the cache on the server, too hard to predict that this won't cause gaps in the frontend cache and subsequent errors over time. * forgot to commit the change to not set the self.storage property of the model * Update feedback api.py --------- Co-authored-by: bmartel <bmartel@users.noreply.github.com> * fix: LSDV-5178: Update django version to fix CVE-2023-31047 (#4245) Update django version to fix CVE-2023-31047 Co-authored-by: nik <nik@heartex.net> * fix: LSDV-5199: API docs redoc version updated to fix DOMPurify incompatibility (#4267) * [submodules] Build static heartexlabs/label-studio-frontend * docs: LSF Update * [submodules] Build static heartexlabs/dm2 * [submodules] Build static heartexlabs/dm2 * [submodules] Build static heartexlabs/label-studio-frontend --------- Co-authored-by: bmartel <brandonmartel@gmail.com> Co-authored-by: bmartel <bmartel@users.noreply.github.com> Co-authored-by: niklub <lubimov.nicolas@gmail.com> Co-authored-by: nik <nik@heartex.net> Co-authored-by: Travis Clark <travisjosephclark@gmail.com>
shayantabatabaee
pushed a commit
to shayantabatabaee/label-studio
that referenced
this pull request
Sep 19, 2023
…eated_at (HumanSignal#4259) * feat: LSDV-5035: Use created_at from draft as the annotation created_at * fix the update statement as it cannot be mass assigned and should not be open to this * save the draft created at to its own field to not disturb existing data * [submodules] Build static heartexlabs/dm2 * [submodules] Build static heartexlabs/dm2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
It was observed that the created_at date seemingly changes throughout the lifecycle of an annotation which causes some ui issues, but this is actually not true. The issue is that annotations that started as a saved draft become
created_atthe time the annotation is created. So this makes it so the connected draft_created_at keeps from from the draft through to the associated annotation so it can be used in the UI for filtering and sorting and maintain a consistent historical order for annotation tabs.What feature flags were used to cover this change?
fflag_feat_back_lsdv_5035_use_created_at_from_draft_for_annotation_256052023_shortDoes this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
Annotation, Draft