Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LSDV-2775: fix predictions selector in next task with ML backend model version #4363

Merged
merged 7 commits into from
Jul 14, 2023

Conversation

niklub
Copy link
Collaborator

@niklub niklub commented Jun 12, 2023

… model version dropdown

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

@netlify
Copy link

netlify bot commented Jun 12, 2023

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit a6d401e
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/64b191dfdbdf840008afc02a
😎 Deploy Preview https://deploy-preview-4363--label-studio-docs-new-theme.netlify.app/guide/ml
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jun 12, 2023

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit a6d401e
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/64b191df128ccc0008921358
😎 Deploy Preview https://deploy-preview-4363--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the fix label Jun 12, 2023
@farioas
Copy link
Member

farioas commented Jul 12, 2023

/git merge develop

Successfully pushed new changes:
Merge remote-tracking branch 'origin/develop' into fb-lsdv-2775 (cf7a85d)

Workflow run

Copy link
Contributor

@bmartel bmartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fails on CI https://github.com/heartexlabs/label-studio/actions/runs/5534708309/jobs/10100011661#step:13:1169, looks good otherwise though. Seems like there is no ml_backend set.

@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03 🎉

Comparison is base (c5b3700) 75.65% compared to head (a6d401e) 75.69%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4363      +/-   ##
===========================================
+ Coverage    75.65%   75.69%   +0.03%     
===========================================
  Files          156      156              
  Lines        12299    12316      +17     
===========================================
+ Hits          9305     9322      +17     
  Misses        2994     2994              

see 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dredivaris dredivaris requested a review from bmartel July 14, 2023 18:36
@dredivaris dredivaris merged commit 8ebbe48 into develop Jul 14, 2023
39 checks passed
shayantabatabaee pushed a commit to shayantabatabaee/label-studio that referenced this pull request Sep 19, 2023
… model version (HumanSignal#4363)

* fix: LSDV-2775: fix predictions selector in next task with ML backend model version dropdown

* Add ml backend test for auto update enabled/disabled

* feat: LSDV-5386: update ml model documenation to support model setup changes and auto-update feature selection

* Fix missing mock endpoint

---------

Co-authored-by: nik <nik@heartex.net>
Co-authored-by: farioas <farioas@users.noreply.github.com>
Co-authored-by: andreasdivaris <dredivaris@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants