Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LSDV-5375: fix session and queue tests #4488

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Conversation

dredivaris
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Tests

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 3f21db7
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/64a867817422120008cad3c7

@netlify
Copy link

netlify bot commented Jul 7, 2023

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 3f21db7
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/64a86781ecfb12000750f98f

@github-actions github-actions bot added the fix label Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1b9963f) 75.44% compared to head (3f21db7) 75.44%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4488   +/-   ##
========================================
  Coverage    75.44%   75.44%           
========================================
  Files          156      156           
  Lines        12314    12314           
========================================
  Hits          9290     9290           
  Misses        3024     3024           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@jombooth jombooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dredivaris dredivaris merged commit 2a11add into develop Jul 7, 2023
39 checks passed
shayantabatabaee pushed a commit to shayantabatabaee/label-studio that referenced this pull request Sep 19, 2023
@deppp deppp deleted the fb-LSDV-5375 branch November 14, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants