fix: LSDV-4907: Import - validate filetypes on the FE #4515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
jombooth
commented
Jul 14, 2023
bmartel
requested changes
Jul 14, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #4515 +/- ##
========================================
Coverage 75.65% 75.65%
========================================
Files 156 156
Lines 12299 12299
========================================
Hits 9305 9305
Misses 2994 2994 ☔ View full report in Codecov by Sentry. |
bmartel
approved these changes
Jul 18, 2023
….com:heartexlabs/label-studio into fb-LSDV-4907/frontend-checks-file-extensions
MihajloHoma
approved these changes
Jul 18, 2023
auto-merge was automatically disabled
July 18, 2023 15:44
Pull request was converted to draft
shayantabatabaee
pushed a commit
to shayantabatabaee/label-studio
that referenced
this pull request
Sep 19, 2023
* fix: LSDV-4907: Import - validate filetypes on the FE * ci: Build frontend Workflow run: https://github.com/heartexlabs/label-studio/actions/runs/5549397332 * use semicolons * ci: Build frontend Workflow run: https://github.com/heartexlabs/label-studio/actions/runs/5549447635 * remove aiff and au since those are not supported anymore, FE+BE * ci: Build frontend Workflow run: https://github.com/heartexlabs/label-studio/actions/runs/5582119630 * add jpEg as on the BE, add note about keeping compatibility * actually add jpEg * ci: Build frontend Workflow run: https://github.com/heartexlabs/label-studio/actions/runs/5583232992 --------- Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
https://labelstudio.aha.io/develop/comments/7247239546298336794
We have filetype validation on the backend, but we want it on the frontend also to show more helpful error messages to users, and avoid server calls that will 4xx. We could check filetypes in greater depth on the FE but since we also have backend validation I feel that's not necessary and this lightweight approach will suffice.
Also remove
.aiffand.aubecause per @bmartel these are not supported by the backendWhat does this fix?
(if this is a bug fix)
What is the new behavior?
(if this is a breaking or feature change)
Attempt to add multiple files, one of which is the wrong type. None will be uploaded and we'll show an error for the first invalid file.
Files with valid extensions upload as before, and the error state is cleared as expected.
What is the current behavior?
(if this is a breaking or feature change)
What libraries were added/updated?
(list all with version changes)
Does this change affect performance?
(if so describe the impacts positive or negative)
Does this change affect security?
(if so describe the impacts positive or negative)
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
The Import component in the FE.