Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LSDV-5356: Fix is_labeled state #4517

Merged
merged 6 commits into from
Aug 14, 2023
Merged

fix: LSDV-5356: Fix is_labeled state #4517

merged 6 commits into from
Aug 14, 2023

Conversation

triklozoid
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

@netlify
Copy link

netlify bot commented Jul 14, 2023

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit 65a3520
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/64da53b0f980190008e0be58
😎 Deploy Preview https://deploy-preview-4517--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 14, 2023

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit 65a3520
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/64da53b01e794a00088978de
😎 Deploy Preview https://deploy-preview-4517--heartex-docs.netlify.app/guide/billing
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the fix label Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.23% 🎉

Comparison is base (d0bcfa1) 75.56% compared to head (cbd0583) 75.80%.

❗ Current head cbd0583 differs from pull request most recent head 65a3520. Consider uploading reports for the commit 65a3520 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4517      +/-   ##
===========================================
+ Coverage    75.56%   75.80%   +0.23%     
===========================================
  Files          157      157              
  Lines        12468    12435      -33     
===========================================
+ Hits          9422     9426       +4     
+ Misses        3046     3009      -37     

see 15 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jombooth jombooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the test

@triklozoid triklozoid enabled auto-merge (squash) August 14, 2023 16:18
@triklozoid triklozoid merged commit 00b3307 into develop Aug 14, 2023
26 of 36 checks passed
shayantabatabaee pushed a commit to shayantabatabaee/label-studio that referenced this pull request Sep 19, 2023
* fix: LSDV-5356: Fix is_labeled state

* Added test and fixed the docstring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants