fix: LSDV-5222: custom weights reset following labeling interface changes #4611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… label weights when changing label names
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #4611 +/- ##
===========================================
+ Coverage 75.73% 75.81% +0.08%
===========================================
Files 157 157
Lines 12457 12466 +9
===========================================
+ Hits 9434 9451 +17
+ Misses 3023 3015 -8 ☔ View full report in Codecov by Sentry. |
wesleylima
reviewed
Aug 7, 2023
wesleylima
approved these changes
Aug 7, 2023
triklozoid
approved these changes
Aug 8, 2023
dredivaris
changed the title
github-actions
bot
added
fix
title needs formatting
and removed
title needs formatting
labels
AndrejOros
approved these changes
Aug 14, 2023
shayantabatabaee
pushed a commit
to shayantabatabaee/label-studio
that referenced
this pull request
Sep 19, 2023
…nges (HumanSignal#4611) * feat: LSDV-5222: Add ids to labels to allow for persistence of custom label weights when changing label names * Revert changes related to using a label id and add fix for resetting labels set to 0 * Update get_label so it doesn't have to be called twice in comprehension * Update so overall section is also covered when it is set to 0 * Fix fetching of overall weight as there are subtle issues with the default values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
What does this fix?
When custom weight is set to zero and anything is changed in the labeling interface, the custom weight is reset to 1.0. This is because a check in the code interprets zero as False.
What is the new behavior?
The fix it to update the check to only interpret None as not set (0 will now qualify as being set and not trigger an update to the default).
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
Labeling Interface / Custom Weights