Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LEAP-12: Change the login page and add tips #4649

Merged
merged 10 commits into from
Aug 22, 2023
Merged

Conversation

juliosgarbi
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 6b3d211
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/64e4c15c325bb60007c8bb1b

@netlify
Copy link

netlify bot commented Aug 17, 2023

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 6b3d211
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/64e4c15c9512a60008228216

@github-actions github-actions bot added the feat label Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02% ⚠️

Comparison is base (9d52447) 75.86% compared to head (ff1d2e1) 75.85%.
Report is 2 commits behind head on develop.

❗ Current head ff1d2e1 differs from pull request most recent head 6b3d211. Consider uploading reports for the commit 6b3d211 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4649      +/-   ##
===========================================
- Coverage    75.86%   75.85%   -0.02%     
===========================================
  Files          157      157              
  Lines        12492    12502      +10     
===========================================
+ Hits          9477     9483       +6     
- Misses        3015     3019       +4     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliosgarbi juliosgarbi changed the title feat: LEAP-12: change the login page and add tips feat: LEAP-12: Change the login page and add tips Aug 18, 2023
@juliosgarbi
Copy link
Contributor Author

juliosgarbi commented Aug 18, 2023

/git merge develop

Successfully pushed new changes:
Merge remote-tracking branch 'origin/develop' into fb-leap-12 (cc3f39c)

Workflow run

Copy link
Contributor

@bmartel bmartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The background svg seems quite large in this format, I would have to see what in particular this is facilitating but for now this will be ok.

@juliosgarbi
Copy link
Contributor Author

juliosgarbi commented Aug 22, 2023

/git merge develop

Successfully pushed new changes:
Merge remote-tracking branch 'origin/develop' into fb-leap-12 (ff1d2e1)

Workflow run

@juliosgarbi juliosgarbi enabled auto-merge (squash) August 22, 2023 14:10
@juliosgarbi juliosgarbi merged commit cc5b406 into develop Aug 22, 2023
26 of 36 checks passed
@sentry-io
Copy link

sentry-io bot commented Aug 25, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ UnicodeEncodeError: 'ascii' codec can't encode character '\uc608' in position 343: ordinal not in range(128) /api/projects/{pk}/validate/ View Issue
  • ‼️ UnicodeEncodeError: 'ascii' codec can't encode character '\uc608' in position 343: ordinal not in range(128) /api/projects/{pk}/validate/ View Issue
  • ‼️ UnicodeEncodeError: 'ascii' codec can't encode character '\uc608' in position 343: ordinal not in range(128) /api/projects/{pk}/validate/ View Issue
  • ‼️ UnicodeEncodeError: 'ascii' codec can't encode character '\uc608' in position 343: ordinal not in range(128) /api/projects/{pk}/validate/ View Issue
  • ‼️ UnicodeEncodeError: 'ascii' codec can't encode character '\uc608' in position 343: ordinal not in range(128) /api/projects/{pk}/validate/ View Issue

Did you find this useful? React with a 👍 or 👎

shayantabatabaee pushed a commit to shayantabatabaee/label-studio that referenced this pull request Sep 19, 2023
* feat: LEAP-12: change the login page and add tips

* add gtm params

* Fix tips

* Support SERVER_ID

* Add server ID

* Fix tip text

* Move server_id assignment

* change svg import to external

---------

Co-authored-by: juliosgarbi <juliosgarbi@users.noreply.github.com>
Co-authored-by: Nick Skriabin <nr@fenelon.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants