Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LSDV-5520: Project Creation Wizard Tip (Label Studio Community) #4652

Merged
merged 35 commits into from
Aug 22, 2023

Conversation

nicholasrq
Copy link
Member

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit 80f6a1c
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/64e4bbd71519be0008ec36a0
😎 Deploy Preview https://deploy-preview-4652--heartex-docs.netlify.app/guide/billing
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the feat label Aug 18, 2023
@netlify
Copy link

netlify bot commented Aug 18, 2023

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit 80f6a1c
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/64e4bbd7238a3a000797cc7f
😎 Deploy Preview https://deploy-preview-4652--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@bmartel bmartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me so far, I think this is an initial pass and there will be a follow up to fill in some of the param details correct?

<Select placeholder="Select an option" disabled options={[]} />
<Caption>
Simplify project management by organizing projects into workspaces.
<a href={createURL('https://docs.humansignal.com/guide/manage_projects#Create-workspaces-to-organize-projects', {

Check warning

Code scanning / CodeQL

Potentially unsafe external link Medium

External links without noopener/noreferrer are a potential security risk.
@nicholasrq nicholasrq force-pushed the fb-lsdv-5520/project-creation-tip branch from 186ab46 to 5d8cb27 Compare August 21, 2023 13:01
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9d52447) 75.86% compared to head (80f6a1c) 75.86%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4652   +/-   ##
========================================
  Coverage    75.86%   75.86%           
========================================
  Files          157      157           
  Lines        12492    12497    +5     
========================================
+ Hits          9477     9481    +4     
- Misses        3015     3016    +1     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliosgarbi
Copy link
Contributor

juliosgarbi commented Aug 22, 2023

/git merge develop

Successfully pushed new changes:
Merge remote-tracking branch 'origin/develop' into fb-lsdv-5520/project-creation-tip (80f6a1c)

Workflow run

@juliosgarbi juliosgarbi merged commit 8826cf2 into develop Aug 22, 2023
39 checks passed
shayantabatabaee pushed a commit to shayantabatabaee/label-studio that referenced this pull request Sep 19, 2023
…HumanSignal#4652)

* Introduce Heidi tips

* ci: Build frontend

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/5901625542

* Fix random tip selection

* ci: Build frontend

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/5902201016

* Cookie to dismiss tips

* ci: Build frontend

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/5903825521

* Caption component

* Fix caption styles

* Use caption in project creation

* ci: Build frontend

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/5904073950

* Option to add URL params to the links

* ci: Build frontend

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/5904701057

* Add feature flag

* ci: Build frontend

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/5904791829

* fix some lint issues

* ci: Build frontend

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/5907055489

* add new GA params

* add new GA params

* ci: Build frontend

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/5907116794

* move the code to be defined before HeidiTip

* ci: Build frontend

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/5907139364

* add link to workspace dropdown

* ci: Build frontend

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/5907221213

* Fix typo

* Fix link behavior

* ci: Build frontend

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/5925171669

* Add server_id and user_id to createURL

* Remove unnecessary server_id from content

* Remove unnecessary server and user ids from project creation tip

* ci: Build frontend

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/5925352703

* Support SERVER_ID

* Remove placeholder

* ci: Build frontend

Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/5926601530

* Move server_id assignment

---------

Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com>
Co-authored-by: Julio Sgarbi <julio.sgarbi@hotmail.com>
Co-authored-by: juliosgarbi <juliosgarbi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants