Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LSDV-5545: Update conversational analysis template to include contextual scrolling by default #4675

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

bmartel
Copy link
Contributor

@bmartel bmartel commented Aug 22, 2023

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Config

Describe the reason for change

By default we will now be enabling contextscroll mode in the "Conversational Analysis" template, as it is a direct improvement targeted to that use case.

Screen Shot 2023-08-22 at 11 57 56 AM

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

Which logical domain(s) does this change affect?

Templates

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit a933a51
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/64e4e9e951a20700080f30bc
😎 Deploy Preview https://deploy-preview-4675--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Aug 22, 2023

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit a933a51
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/64e4e9e9b0f77a0008db0740
😎 Deploy Preview https://deploy-preview-4675--heartex-docs.netlify.app/guide/billing
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the feat label Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (9d52447) 75.86% compared to head (a933a51) 75.87%.
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4675   +/-   ##
========================================
  Coverage    75.86%   75.87%           
========================================
  Files          157      157           
  Lines        12492    12492           
========================================
+ Hits          9477     9478    +1     
+ Misses        3015     3014    -1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@juliosgarbi juliosgarbi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bmartel bmartel merged commit 974eb72 into develop Aug 22, 2023
39 checks passed
@bmartel bmartel deleted the fb-lsdv-5545 branch August 22, 2023 19:42
shayantabatabaee pushed a commit to shayantabatabaee/label-studio that referenced this pull request Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants