Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LSDV-5289-1: Load stats recalculation function from string, call after update task states #4676

Merged
merged 4 commits into from Aug 24, 2023

Conversation

jombooth
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

Attempt 2 at fixing deadlocks. Previously we were performing stats recalculation in parallel with updating task states in LSE.

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

@netlify
Copy link

netlify bot commented Aug 23, 2023

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit db88c38
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/64e68de676153a0008492667

@netlify
Copy link

netlify bot commented Aug 23, 2023

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit db88c38
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/64e68de6fe6db4000829847c

@github-actions github-actions bot added the fix label Aug 23, 2023
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (d431f8a) 75.86% compared to head (db88c38) 75.85%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4676      +/-   ##
===========================================
- Coverage    75.86%   75.85%   -0.01%     
===========================================
  Files          157      157              
  Lines        12515    12531      +16     
===========================================
+ Hits          9494     9505      +11     
- Misses        3021     3026       +5     

see 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jombooth
Copy link
Contributor Author

jombooth commented Aug 23, 2023

/git merge develop

Successfully pushed new changes:
Merge remote-tracking branch 'origin/develop' into fb-LSDV-5289-1/serialize-rq-jobs-deadlocks (db88c38)

Workflow run

@jombooth jombooth marked this pull request as ready for review August 24, 2023 07:26
@jombooth jombooth merged commit 9302ef7 into develop Aug 24, 2023
61 of 62 checks passed
@jombooth jombooth deleted the fb-LSDV-5289-1/serialize-rq-jobs-deadlocks branch August 24, 2023 07:54
@sentry-io
Copy link

sentry-io bot commented Aug 24, 2023

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ AttributeError: 'Settings' object has no attribute 'RECALCULATE_ALL_STATS' projects.models in <module> View Issue

Did you find this useful? React with a 👍 or 👎

shayantabatabaee pushed a commit to shayantabatabaee/label-studio that referenced this pull request Sep 19, 2023
… after update task states (HumanSignal#4676)

* fix: LSDV-5289-1: move stats recalculation to string import

* clarify log messages

* fix confusing log message

---------

Co-authored-by: jombooth <jombooth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants