fix: LSDV-5482: Fix autocomplete Escape in modal #4692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't close modal when Escape is pressed during config editing. This switches modal's escape handlers from capture to bubble event phase.
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
nicholasrq
approved these changes
Aug 25, 2023
AndrejOros
approved these changes
Aug 25, 2023
shayantabatabaee
pushed a commit
to shayantabatabaee/label-studio
that referenced
this pull request
Sep 19, 2023
* fix: LSDV-5482: Fix autocomplete Escape in modal Don't close modal when Escape is pressed during config editing. This switches Create Project modal's escape handler from capture to bubble event phase. * ci: Build frontend Workflow run: https://github.com/HumanSignal/label-studio/actions/runs/5975239509 --------- Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't close modal when Escape is pressed during config editing.
This switches Create Project modal's escape handler from capture to bubble event phase.
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
New UX behaviour appeared after adding autocomplete:
there is a popup with hints in config editor now, and this popup can be closed by pressing Escape, but if editor is in Create Project modal this will close the entire modal, removing project draft and erasing everything added there.
What does this fix?
Don't close modal if editor is focused.
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
Config Editor, Autocomplete, Modal