Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OPTIC-188: Separating swagger and redoc views so that they can be permissioned differently #4931

Merged
merged 8 commits into from
Nov 21, 2023

Conversation

makseq
Copy link
Member

@makseq makseq commented Oct 19, 2023

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)

What does this fix?

(if this is a bug fix)

What is the new behavior?

(if this is a breaking or feature change)

What is the current behavior?

(if this is a breaking or feature change)

What libraries were added/updated?

(list all with version changes)

Does this change affect performance?

(if so describe the impacts positive or negative)

Does this change affect security?

(if so describe the impacts positive or negative)

What alternative approaches were there?

(briefly list any if applicable)

What feature flags were used to cover this change?

(briefly list any if applicable)

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit f3f6bcb
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/655cc9fccafd9d0008b2cf17

@netlify
Copy link

netlify bot commented Oct 19, 2023

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit f3f6bcb
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/655cc9fc9628e10009218d0b

@github-actions github-actions bot added the feat label Oct 19, 2023
@wesleylima wesleylima changed the title feat: OPTIC-188: Add toggle for /swagger url disabling feat: OPTIC-188: Separating swagger and redoc views so that they can be permissioned differently Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fb61157) 76.11% compared to head (f3f6bcb) 76.11%.
Report is 4 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4931   +/-   ##
========================================
  Coverage    76.11%   76.11%           
========================================
  Files          154      154           
  Lines        12790    12792    +2     
========================================
+ Hits          9735     9737    +2     
  Misses        3055     3055           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bmartel bmartel enabled auto-merge (squash) November 21, 2023 15:07
@bmartel bmartel merged commit 4eaaf22 into develop Nov 21, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants