-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LEAP-245: make Number tag complain about missing to_name #5408
Conversation
…label-studio into fb-leap-245/just-number-tag
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5408 +/- ##
========================================
Coverage 75.88% 75.89%
========================================
Files 154 154
Lines 12931 12931
========================================
+ Hits 9813 9814 +1
+ Misses 3118 3117 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please fill in the description!
<Number/>
tag didn't throw validation error if there is missing property oftoName
.PR fulfills these requirements
This change affects (describe how if yes)
Does this PR introduce a breaking change?
What level of testing was included in the change?
Which logical domain(s) does this change affect?
Config Validation
,Number
,Labeling Interface
,Creating Project