Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LEAP-245: make Number tag complain about missing to_name #5408

Merged
merged 7 commits into from
Feb 1, 2024

Conversation

Gondragos
Copy link
Collaborator

@Gondragos Gondragos commented Jan 31, 2024

<Number/> tag didn't throw validation error if there is missing property of toName.

PR fulfills these requirements

  • Tests for the changes have been added/updated
  • Docs have been added/updated
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance

This change affects (describe how if yes)

  • Performance
  • Security
  • UX

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

  • e2e (codecept)
  • integration (cypress)
  • unit (jest)
  • python!

Which logical domain(s) does this change affect?

Config Validation, Number, Labeling Interface, Creating Project

Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 02f1dd5
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/65bac65e6252d6000950f8be

Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 02f1dd5
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/65bac65e6252d6000950f8bc

@github-actions github-actions bot added the fix label Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d6ddac) 75.88% compared to head (02f1dd5) 75.89%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5408   +/-   ##
========================================
  Coverage    75.88%   75.89%           
========================================
  Files          154      154           
  Lines        12931    12931           
========================================
+ Hits          9813     9814    +1     
+ Misses        3118     3117    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jombooth jombooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please fill in the description!

@Gondragos Gondragos merged commit dabf7b8 into develop Feb 1, 2024
39 of 40 checks passed
@Gondragos Gondragos deleted the fb-leap-245/just-number-tag branch February 1, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants