Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LEAP-824: Remove duplicated tasks with moving of annotations #5572

Merged
merged 12 commits into from
Mar 18, 2024

Conversation

makseq
Copy link
Member

@makseq makseq commented Mar 13, 2024

This PR moves previously hidden behind EXPERIMENTAL_FEATURES=1 flag remove_duplicates to public access.
Also it adds slight code refactoring and a new feature: moving annotations to the "first" task among duplicated ones before removing duplicates.

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 6283c18
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/65f84efe58b8b800085f63d4

Copy link

netlify bot commented Mar 13, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 6283c18
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/65f84efee3b73a00088201ad

@github-actions github-actions bot added the feat label Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.18%. Comparing base (b08b623) to head (6283c18).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5572      +/-   ##
===========================================
+ Coverage    75.79%   76.18%   +0.39%     
===========================================
  Files          157      158       +1     
  Lines        13133    13181      +48     
===========================================
+ Hits          9954    10042      +88     
+ Misses        3179     3139      -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@makseq makseq changed the title feat: Remove duplicated tasks with moving of annotations feat: LEAP-824: Remove duplicated tasks with moving of annotations Mar 13, 2024
@makseq makseq merged commit a7c9531 into develop Mar 18, 2024
38 checks passed
@makseq makseq deleted the fb-remove-dup branch March 18, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants