-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LEAP-828: Add handling for carriage return in domManager #5615
Conversation
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
…texlabs/label-studio into fb-leap-828/empty-text-fields
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR definitely requires more description + it has a dangerous change in behaviour
# Conflicts: # web/dist/libs/editor/main.js # web/dist/libs/editor/main.js.map
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small corrections, but that's great fix!
Co-authored-by: hlomzik <hlomzik@gmail.com>
/git merge
|
Update the dom Managed to incorporate the handling of carriage return (CR) characters. This is a necessary change as some operating systems or browsers use both line feed (LF) and carriage return characters.
Previously we had a problem with missing regions when we are trying to render annotation from results that have a wrong order. It was caused by the problem with detecting area type (it thought it was an classification) when we have excessive fields in result (like a text). So in this commit I tried to fix it by adding expected values from value after creating an area and directly to the text field of
RichTextRegion
. (see HumanSignal/label-studio-frontend@6ef0657#diff-9386d502ec5e5d9e8b50c2c679499430ca58728900aac1a43de33d13ee2648f4)PR fulfills these requirements
Describe the reason for change
There was a situation when, when opening an annotation with richtext, some regions could receive incorrect text values, which led to saving the results without text inside.
This change affects (describe how if yes)
Does this PR introduce a breaking change?
What level of testing was included in the change?
Which logical domain(s) does this change affect?
HyperText
,RichText
,Text
,domManager