fix: Set model as prelabeler #5695
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
state (i.e. no predictions were selected). Fixing a bug with model version getting reset on patch request Adding tests
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5695 +/- ##
========================================
Coverage 75.95% 75.96%
========================================
Files 158 158
Lines 13327 13331 +4
========================================
+ Hits 10123 10127 +4
Misses 3204 3204
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
15 tasks
|
Closed in favor of #5709 |
hlomzik
added a commit
that referenced
this pull request
Apr 18, 2024
This code sets a model as a default prelabeler in case no other option was selected. This is done to keep it consistent with how offline predictions are used when uploaded (they get selected). That's basically a #5695 fixed for Follow Merge ### PR fulfills these requirements - [x] Tests for the changes have been added/updated (for bug fixes/features) - [ ] Docs have been added/updated (for bug fixes/features) - [x] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.) - [x] Self-reviewed and ran all changes on a local instance (for bug fixes/features) #### Change has impacts in these area(s) - [ ] Product design - [x] Backend (Database) - [x] Backend (API) - [ ] Frontend ### Describe the reason for change Label Stream and other flows have some issues when model is added but not selected because of discrepancies in logic. #### What alternative approaches were there? We could change the way model is added and handled in settings, but autoselect is small and precise fix. ### Does this PR introduce a breaking change? - [ ] Yes, and covered entirely by feature flag(s) - [ ] Yes, and covered partially by feature flag(s) - [x] No - [ ] Not sure (briefly explain the situation below) ### What level of testing was included in the change? - [ ] e2e - [x] integration - [ ] unit --------- Co-authored-by: Michael Malyuk <michael.malyuk@icloud.com> Co-authored-by: Jo Booth <jo.m.booth@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code sets a model as a default prelabeler in case no other option was selected. This is done to keep it consistent with how offline predictions are used when uploaded (they get selected).
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change madeex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errorsChange has impacts in these area(s)
(check all that apply)
Describe the reason for change
(link to issue, supportive screenshots etc.)
What does this fix?
(if this is a bug fix)
What is the new behavior?
(if this is a breaking or feature change)
What is the current behavior?
(if this is a breaking or feature change)
What libraries were added/updated?
(list all with version changes)
Does this change affect performance?
(if so describe the impacts positive or negative)
Does this change affect security?
(if so describe the impacts positive or negative)
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)