fix: LEAP-930: Autoselect model as prelabeler when its added #5697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
state (i.e. no predictions were selected). Fixing a bug with model version getting reset on patch request Adding tests
makseq
approved these changes
Apr 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## ls-release/1.12.0 #5697 +/- ##
==================================================
Coverage 76.21% 76.21%
==================================================
Files 158 158
Lines 13330 13334 +4
==================================================
+ Hits 10159 10163 +4
Misses 3171 3171 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code sets a model as a default prelabeler in case no other option was selected. This is done to keep it consistent with how offline predictions are used when uploaded (they get selected).
Mirror of #5709
PR fulfills these requirements
Change has impacts in these area(s)
Describe the reason for change
Label Stream and other flows have some issues when model is added but not selected because of discrepancies in logic.
What alternative approaches were there?
We could change the way model is added and handled in settings, but autoselect is small and precise fix.
Does this PR introduce a breaking change?
What level of testing was included in the change?