Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: LEAP-930: Changes to ML settings UI #5712

Merged
merged 11 commits into from
Apr 18, 2024
Merged

fix: LEAP-930: Changes to ML settings UI #5712

merged 11 commits into from
Apr 18, 2024

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Apr 10, 2024 •
edited

Annotation settings:

  • remove links to docs as they don't fully describe the flow

Model settings:

  • also remove links
  • fix text describing how to use new model in labeling
  • add link to Annotation settings
  • simplify blocks used on a page
Screenshot 2024-04-10 at 23 58 00 Screenshot 2024-04-10 at 23 57 48

Mirroring #5696 for Follow Merge

PR fulfills these requirements

  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

@github-actions github-actions bot added the fix label Apr 10, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 10, 2024 •
edited

✅ Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit f76146f
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/662149de66d13f0009c86b06

@netlify Netlify
Copy link

netlify bot commented Apr 10, 2024 •
edited

✅ Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit f76146f
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/662149decf5ae80008a5bd7f

@hlomzik
Improve style and mock-ups
026b594
@hlomzik
Simplify callout block in Model settings
8afa932 
We autoselect model_version now, so user action is not required.
@hlomzik hlomzik changed the title fix: LEAP-930: Changes to some settings UI fix: LEAP-930: Changes to ML settings UI Apr 10, 2024
@hlomzik hlomzik mentioned this pull request Apr 10, 2024
Merged
hlomzik added a commit that referenced this pull request Apr 11, 2024
@hlomzik @deppp
fix: LEAP-930: Improve ML related texts in settings (#5713)
224b72e 
Mirroring #5712

---------

Co-authored-by: Michael Malyuk <michael.malyuk@icloud.com>
Co-authored-by: Michael Malyuk <28912+deppp@users.noreply.github.com>
@hlomzik hlomzik mentioned this pull request Apr 11, 2024
Closed
16 tasks
yyassi-heartex
yyassi-heartex approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@yyassi-heartex yyassi-heartex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving with the expectation that there will be a follow up ticket to address my concern regarding the layout/component structure of the description content

@hlomzik
Copy link
Collaborator Author

hlomzik commented Apr 18, 2024 •
edited by robot-ci-heartex

/git merge

Workflow run
Successfully merged: 441 files changed, 2628 insertions(+), 2411 deletions(-)

@hlomzik hlomzik enabled auto-merge (squash) April 18, 2024 16:37
@hlomzik hlomzik merged commit e9163ee into develop Apr 18, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yyassi-heartex yyassi-heartex yyassi-heartex approved these changes

Assignees
No one assigned
Labels
Confirmed fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hlomzik @yyassi-heartex @robot-ci-heartex @deppp