Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LEAP-1004: Show prediction with selected project.model_version in QuickView #5729

Merged
merged 6 commits into from
Apr 17, 2024

Conversation

niklub
Copy link
Collaborator

@niklub niklub commented Apr 15, 2024

In "QuickView" mode, user now sees the prelabeled data from the prediction based on selected model version.
If prediction from this model is not presented it fallbacks to old behavior and uses the first prediction.

Model version selected:
image

Correct prediction is shown first:
image
image

PR fulfills these requirements

  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit a8abb14
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/661e73f754c77000089429a7

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit a8abb14
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/661e73f744c9a9000965d176

@github-actions github-actions bot added the fix label Apr 15, 2024
@deppp
Copy link
Collaborator

deppp commented Apr 16, 2024

Why do we think this is a correct behavior? That should be an EXPLICIT user action to select what predictions should be used?

@niklub
Copy link
Collaborator Author

niklub commented Apr 16, 2024

/git merge develop

Workflow run
Successfully merged: 327 files changed, 70 insertions(+), 14 deletions(-)

@niklub
Copy link
Collaborator Author

niklub commented Apr 16, 2024

Why do we think this is a correct behavior? That should be an EXPLICIT user action to select what predictions should be used?

In the current implementation, the only explicit user action is to set the model version in project settings, which produces the bug fixed in this PR.

Two alternatives that could be better from UX perspective:

  • either let the user create annotation from prediction manually, without pre-initializing it (downside: it can break existing QuickView labeling flow without or with a single prediction, or introduce inconsistency)
  • or let the user copy predictions into the draft annotation (downside: this tool has to be implemented)

Is there any other scenario that can better address the problem?

Anyway, this PR obviously fixes an incorrect behavior, and we can address future enhancements in the next ones

@niklub niklub merged commit 0870d61 into develop Apr 17, 2024
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants