Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LEAP-433: Fix cursor disappearence issue in labeling interface #5730

Merged
merged 5 commits into from
Apr 19, 2024

Conversation

juliosgarbi
Copy link
Contributor

@juliosgarbi juliosgarbi commented Apr 15, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

This PR addresses the cursor disappearance issue observed in the labeling interface, because canvas always has 100% width despite the image size and brushing cursor over the canvas is a grey-ish circle, practically invisible over lightgrey background.

5a6a0f4a-10f3-43e0-8ab6-75bbf112e2fa

What does this fix?

The proposed solution is to introduce a thin black border around the cursor, enhancing its visibility against varying background contrasts.

Screen-Recording-2024-04-15-at-13 04 58

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 7f1b983
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6622928909db0700086b71b8

@github-actions github-actions bot added the fix label Apr 15, 2024
Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 7f1b983
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/662292891f2d2b0007cfc574

@juliosgarbi
Copy link
Contributor Author

juliosgarbi commented Apr 19, 2024

/git merge develop

Workflow run
Successfully merged: 360 files changed, 907 insertions(+), 822 deletions(-)

@juliosgarbi juliosgarbi enabled auto-merge (squash) April 19, 2024 15:44
@juliosgarbi juliosgarbi merged commit 4fa8465 into develop Apr 19, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants