Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LEAP-1023: Fix misspelled LocalFilesImportStorageLink in remove_duplicates #5758

Merged
merged 4 commits into from
Apr 19, 2024

Conversation

makseq
Copy link
Member

@makseq makseq commented Apr 19, 2024

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Right now remove duplicates from Local Storages raises error because there is a misspell in code:

LocalFilesImportStorageLink => LocalFilesImportStorageLink

What does this fix?

Just rename import model.

What is the current behavior?

Remove duplicates from DM actions fails when applied to files from Local Storage.

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

@github-actions github-actions bot added the fix label Apr 19, 2024
Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit c5312a5
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/662286e58dfb1b00089bc45f

Copy link

netlify bot commented Apr 19, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit c5312a5
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/662286e5b94d63000850ee94

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.92%. Comparing base (9f1cba7) to head (f87b4d8).
Report is 4 commits behind head on develop.

❗ Current head f87b4d8 differs from pull request most recent head c5312a5. Consider uploading reports for the commit c5312a5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5758   +/-   ##
========================================
  Coverage    75.92%   75.92%           
========================================
  Files          158      158           
  Lines        13356    13357    +1     
========================================
+ Hits         10140    10141    +1     
  Misses        3216     3216           
Flag Coverage Δ
pytests 75.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@makseq makseq enabled auto-merge (squash) April 19, 2024 13:44
@makseq makseq merged commit ff7105f into develop Apr 19, 2024
35 checks passed
@makseq makseq deleted the fb-LEAP-1023 branch April 19, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants