-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: #5787 Support uppercased version of "COLLECT_ANALYTICS" env var #5788
fix: #5787 Support uppercased version of "COLLECT_ANALYTICS" env var #5788
Conversation
👷 Deploy request for label-studio-docs-new-theme pending review.Visit the deploys page to approve it
|
👷 Deploy request for heartex-docs pending review.Visit the deploys page to approve it
|
Adding fallback to old lowercased version for legacy compatibility.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5788 +/- ##
========================================
Coverage 75.93% 75.93%
========================================
Files 158 158
Lines 13363 13363
========================================
Hits 10147 10147
Misses 3216 3216
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…5788) - [x] Commit message(s) and PR title follows the format `[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made` ex. `fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors` - [x] Tests for the changes have been added/updated (for bug fixes/features) - [x] Docs have been added/updated (for bug fixes/features) - [x] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.) - [x] Self-reviewed and ran all changes on a local instance (for bug fixes/features) _(check all that apply)_ - [ ] Product design - [ ] Backend (Database) - [x] Backend (API) - [ ] Frontend _(link to issue, supportive screenshots etc.)_ #5787 _(if this is a bug fix)_ Updates `base.py` to search for `COLLECT_ANALYTICS` environment variable instead of `collect_analytics` _(if this is a breaking or feature change)_ _(if this is a breaking or feature change)_ _(list all with version changes)_ _(if so describe the impacts positive or negative)_ _(if so describe the impacts positive or negative)_ Positive: backend analytics are properly disabled when deploying with Helm. _(briefly list any if applicable)_ _(briefly list any if applicable)_ _(check only one)_ - [ ] Yes, and covered entirely by feature flag(s) - [ ] Yes, and covered partially by feature flag(s) - [ ] No - [x] Not sure (briefly explain the situation below) The environment variable name is changing to all upper-case - no impact if using Helm, as it enforces all caps. Other users who pass variables in with Docker Compose or other setup methods may already be using lower case, and their setup methods may not enforce all-caps. _(check all that apply)_ - [ ] e2e - [ ] integration - [x] unit _(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)_ Analytics / logging --------- Co-authored-by: Jo Booth <jo.m.booth@gmail.com>
…5788) ### PR fulfills these requirements - [x] Commit message(s) and PR title follows the format `[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made` ex. `fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors` - [x] Tests for the changes have been added/updated (for bug fixes/features) - [x] Docs have been added/updated (for bug fixes/features) - [x] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.) - [x] Self-reviewed and ran all changes on a local instance (for bug fixes/features) #### Change has impacts in these area(s) _(check all that apply)_ - [ ] Product design - [ ] Backend (Database) - [x] Backend (API) - [ ] Frontend ### Describe the reason for change _(link to issue, supportive screenshots etc.)_ #5787 #### What does this fix? _(if this is a bug fix)_ Updates `base.py` to search for `COLLECT_ANALYTICS` environment variable instead of `collect_analytics` #### What is the new behavior? _(if this is a breaking or feature change)_ #### What is the current behavior? _(if this is a breaking or feature change)_ #### What libraries were added/updated? _(list all with version changes)_ #### Does this change affect performance? _(if so describe the impacts positive or negative)_ #### Does this change affect security? _(if so describe the impacts positive or negative)_ Positive: backend analytics are properly disabled when deploying with Helm. #### What alternative approaches were there? _(briefly list any if applicable)_ #### What feature flags were used to cover this change? _(briefly list any if applicable)_ ### Does this PR introduce a breaking change? _(check only one)_ - [ ] Yes, and covered entirely by feature flag(s) - [ ] Yes, and covered partially by feature flag(s) - [ ] No - [x] Not sure (briefly explain the situation below) The environment variable name is changing to all upper-case - no impact if using Helm, as it enforces all caps. Other users who pass variables in with Docker Compose or other setup methods may already be using lower case, and their setup methods may not enforce all-caps. ### What level of testing was included in the change? _(check all that apply)_ - [ ] e2e - [ ] integration - [x] unit ### Which logical domain(s) does this change affect? _(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)_ Analytics / logging --------- Co-authored-by: Jo Booth <jo.m.booth@gmail.com>
PR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
(check all that apply)
Describe the reason for change
(link to issue, supportive screenshots etc.)
#5787
What does this fix?
(if this is a bug fix)
Updates
base.py
to search forCOLLECT_ANALYTICS
environment variable instead ofcollect_analytics
What is the new behavior?
(if this is a breaking or feature change)
What is the current behavior?
(if this is a breaking or feature change)
What libraries were added/updated?
(list all with version changes)
Does this change affect performance?
(if so describe the impacts positive or negative)
Does this change affect security?
(if so describe the impacts positive or negative)
Positive: backend analytics are properly disabled when deploying with Helm.
What alternative approaches were there?
(briefly list any if applicable)
What feature flags were used to cover this change?
(briefly list any if applicable)
Does this PR introduce a breaking change?
(check only one)
The environment variable name is changing to all upper-case - no impact if using Helm, as it enforces all caps. Other users who pass variables in with Docker Compose or other setup methods may already be using lower case, and their setup methods may not enforce all-caps.
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)
Analytics / logging