fix: OPTIC-712: Remove warnings in the app related to injection occur… #5820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
bmartel
approved these changes
May 3, 2024
luarmr
force-pushed
the
fb-optic-712/remove-warnings
branch
from
b237781
to
b7e51c6
Compare
luarmr
force-pushed
the
fb-optic-712/remove-warnings
branch
2 times, most recently
from
4cc49ac
to
6c074dd
Compare
hlomzik
approved these changes
May 7, 2024
There was a problem hiding this comment.
This can even be improved further because some of components (RelationsTab, InfoTab) don't need store, so inject() can also be removed; plus for the rest observer() can be moved to component declaration as well for consistency.
But it's ok like this to fix the bug!
luarmr
force-pushed
the
fb-optic-712/remove-warnings
branch
from
6408d8c
to
dd175af
Compare
luarmr
force-pushed
the
fb-optic-712/remove-warnings
branch
from
a606cae
to
ce1059e
Compare
luarmr
force-pushed
the
fb-optic-712/remove-warnings
branch
from
b952325
to
9f1d0c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing warnings in console: