Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: OPTIC-714: Remove Warning when the page leave datamanager page #5824

Merged
merged 2 commits into from
May 7, 2024

Conversation

luarmr
Copy link
Contributor

@luarmr luarmr commented May 3, 2024

When a user navigates from the datamanager to any other page without it, the console is swamped with errors.

Screenshot 2024-05-03 at 11 57 00 AM Screenshot 2024-05-03 at 11 55 57 AM

@luarmr luarmr requested a review from bmartel May 3, 2024 19:00
@github-actions github-actions bot added the fix label May 3, 2024
Copy link

netlify bot commented May 3, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit fdf8f59
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/663a40e9b8f4c60008810d1c

Copy link

netlify bot commented May 3, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit fdf8f59
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/663a40e925af7400085ce1ee

@luarmr luarmr force-pushed the fb-optic-714/remove-warning branch from 53441eb to 4b36f14 Compare May 6, 2024 15:52
@luarmr luarmr enabled auto-merge (squash) May 6, 2024 15:52
@luarmr luarmr force-pushed the fb-optic-714/remove-warning branch from 45d0f57 to 3ba4b2b Compare May 7, 2024 14:52
@luarmr luarmr merged commit 3bc8a23 into develop May 7, 2024
29 checks passed
hlomzik added a commit that referenced this pull request May 8, 2024
Original fix uses nonexistent method and intent is not clear, so reverting for now
hlomzik added a commit that referenced this pull request May 8, 2024
Hotfix after #5824

---------

Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com>
jombooth pushed a commit that referenced this pull request May 8, 2024
Hotfix after #5824

---------

Co-authored-by: robot-ci-heartex <robot-ci-heartex@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants