This repository has been archived by the owner on Feb 29, 2024. It is now read-only.
move "OK" button below cursor when opening label dialog #893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The intent for this change is to allow faster labeling when there are streaks of the same label occasionally, but not consistently enough to enable "default label" mode. With this PR the user can simply click again to confirm the previous selection, without having to aim for the OK button, or move either hand to the ENTER button. The alignment and position change of the buttons is for two reasons: - it covers less of the drawn shape, easing verification of the label to be selected - the alignment wasn't taken into account for offset calculation. It works if the dialog is shown, but that causes the dialog to briefly flicker in the old position. Presumably an `adjustSize` or similar is needed on more widgets, but I was unable to figure out which.
tzutalin
reviewed
Jun 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent for this change is to allow faster labeling when there
are streaks of the same label occasionally, but not consistently
enough to enable "default label" mode. With this PR the user can
simply click again to confirm the previous selection, without
having to aim for the OK button, or move either hand to the
ENTER key.
The alignment and position change of the buttons is for two reasons:
label to be selected
It works if the dialog is shown, but that causes the dialog to
briefly flicker in the old position. Presumably an
adjustSizeor similar is needed on more widgets, but I was unable to
figure out which.