Change DefaultDateTimeHumanizeStrategy to turn 60 min to one hour not 45

[MehdiK]

DefaultDateTimeHumanizeStrategy has an inconsistent behavior: it returns 59 seconds for 59 seconds but returns one hour for 45 minutes!! If someone wants 45 minutes to report an hour, they would most likely want 45 seconds to return a minute too, in which case they can use the PrecisionDateTimeHumanizeStrategy that does this.

[preetksingh80]

hey, MehdiK,

I have picked up this issue, I was just looking at the test and in

DateHumanizeDefaultStrategyTests

, the test below says that when you pass 45 minutes, it should return "and hour ago"

[Theory]
        //[InlineData(1, "a minute ago")]
        //[InlineData(10, "10 minutes ago")]
        //[InlineData(44, "44 minutes ago")]
        [InlineData(45, "an hour ago")]
        //[InlineData(119, "an hour ago")]
        //[InlineData(120, "2 hours ago")]
        public void MinutesAgo(int minutes, string expected)
        {
            DateHumanize.Verify(expected, minutes, TimeUnit.Minute, Tense.Past);
        }

Is this the desired behavior. or is the test wrong as well. Please let me know, assuming the test is wrong , i have fixed the both and will ask for a pull request soon.
Many thanks
Preet

[MehdiK]

Hey @preetksingh80,

Cool. Yup. Change away all tests that fail because of this change. Please fetch the latest and rebase before sending the PR as another PR just got merged in. Also check out the contribution guideline for other points.

[preetksingh80]

thanks mate, I am a bit new to github :(, sorry. please you will have to bare with me. also I have fixed it but please can you check if the behavior below would be correct, if so the tests are passing now!

 [InlineData(1, "a minute ago")]
        [InlineData(10, "10 minutes ago")]
        [InlineData(44, "44 minutes ago")]
        [InlineData(45, "45 minutes ago")]
        [InlineData(59, "59 minutes ago")]
        [InlineData(60, "an hour ago")]
        [InlineData(119, "an hour ago")]
        [InlineData(120, "2 hours ago")]

[MehdiK]

No need for apology. That's all good. Push it up :)

[MehdiK]

This was fixed in #278