Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Humanizer not taking into account es-ES locale for certain features #513

Closed
fferegrino opened this issue Jan 19, 2016 · 10 comments
Closed

Comments

@fferegrino
Copy link

I ran into this issue while doing some work with Humanizer.Core and the localisation package Humanizer.Core.es:

For features like Ordinalisation and Pluralisation Humanizer works prefect and takes the locale strings for the language, but for others (such as DateTime & TimeSpan humanisation) it ignores the locale and outputs the result in english. i.e. Outputting One month from now instead of En un mes.

After a quick look at the code I can see that there are tests written for spanish language, though I'm not so sure of what can be wrong.

This is the code I'm working on https://github.com/ThatCSharpGuy/humanize-post/tree/332eb1db6924370db9d1d4f2a9634d73a2a2fd8d

I forked the repo to figure out what can be wrong, but it would be great if anyone could shed some light over this issue (or even if it really is an issue)

@clairernovotny
Copy link
Member

What version of VS are you using and what version of NuGet? In your bin\debug directory, do you see an es directory?

@fferegrino
Copy link
Author

VS Ultimate 2013, .NET 4.5, Humanizer 2.0.0-beta02-0092

And as for that directory: No, there is no directory.

@clairernovotny
Copy link
Member

I just opened your solution in VS 2013, built it and I see the es folder in the bin\debug directory.

I have VS 2013 Update 5 with NuGet 2.8.60723.765 (version from the Extensions and Updates dialog).

What versions do you have?

@fferegrino
Copy link
Author

I have the same NuGet version as you, as well the Update 5 for VS.
Thanks for checking the solution I provided.

I tried on two PC, I'll test later in OSX to see if the folder is generated.

@clairernovotny
Copy link
Member

One thing to try too -- can you delete the \packages folder and then rebuild? VS should restore the packages cleanly again.

@clairernovotny
Copy link
Member

Any updates on this, did that work, can this issue be closed?

@fferegrino
Copy link
Author

Sorry for being away.

Tired on three different computers, two different projects and still no \es folder. Even removing the \packages. Do you think this could be a configuration issue on my machines?

@fferegrino
Copy link
Author

If I manually copy the \es folder from \lib\portable... to my bin\debug it works as expected.

@clairernovotny
Copy link
Member

I would suggest opening an issue at the NuGet repo: https://github.com/NuGet/Home/issues

@SimonCropp
Copy link
Collaborator

@fferegrino sorry for the delayed response. it it not possible to look further into this without a minimal repro, or better yet a PR with a test that illustrates the problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants