Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust IndexOf Usage #1060

Merged
merged 2 commits into from
Apr 30, 2021
Merged

Adjust IndexOf Usage #1060

merged 2 commits into from
Apr 30, 2021

Conversation

dahlbyk
Copy link
Contributor

@dahlbyk dahlbyk commented Apr 30, 2021

Nerd-sniped myself this morning:

  1. Noticed a use of CurrentCultureIgnoreCase in the presence of an IFormatProvider. Since most IFormatProviders are CultureInfo, we can use their CompareInfo.
  2. Noticed a few uses of str.IndexOf(...) == 0 which can be more efficiently written as str.StartsWith(...).

Checklist

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
    • Not sure if it's worth writing a unit test for the CurrentCultureIgnoreCase change? Existing tests pass.
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the dev branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

@clairernovotny clairernovotny merged commit 1285835 into Humanizr:main Apr 30, 2021
@dahlbyk dahlbyk deleted the IndexOf branch April 30, 2021 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants