Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Spanish localization #1172

Merged
merged 34 commits into from
Jan 29, 2022
Merged

Improve Spanish localization #1172

merged 34 commits into from
Jan 29, 2022

Conversation

ohmineer
Copy link

Summary

Improve and fixes Spanish localization including ordinalizers, number to words converter, TimeSpan humanizer, time to clock notation and date to words converters.

Issues

fixes #1166
fixes #1168
fixes #1169

Checklist:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings (See below)
  • There is proper unit test coverage (See below)
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the main branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures (See below)

Code analysis warning

Checked with ReSharper command line tools. Removed warnings on files modified by this PR.

Code coverage

Coverage Ordinalizers and Number To Words Converter
Coverage EsTimeOnly

All tests passed

Test explorer all green

Daniel Serrano added 30 commits December 31, 2021 16:28
@dnfadmin
Copy link

dnfadmin commented Jan 28, 2022

CLA assistant check
All CLA requirements met.

Copy link
Member

@clairernovotny clairernovotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all of this. It looks really good. Just a couple of small things and I can merge it in!

@ohmineer
Copy link
Author

I have also removed a warning I saw in Humanizer-CI tasks details.
Warning Humanizer-CI
o

@clairernovotny clairernovotny merged commit 60822b6 into Humanizr:main Jan 29, 2022
@clairernovotny
Copy link
Member

Thank you for all of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment