Swedish localization (strings, tests) #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Please add the PR to the release-notes file and also write some unit tests based on some of the existing ones - although I think you don't need those many cases as your translation rules are quite simple and map one-to-one to English. Also you need to do two sets of tests for DateTime and TimeSpan. You can see examples of this in the other localisations. |
|
Added tests for DateTime and TimeSpan, removed some necessary tests and added the info to the release notes (hopefully in the correct way). |
| @@ -1,5 +1,7 @@ | |||
| ###In Development | |||
|
|
|||
| - [#135](https://github.com/MehdiK/Humanizer/pull/135): Swedish localization (strings, tests) | |||
|
Cool. Thanks. I will fix the spacing issues and merge. Don't worry about them. |
|
Thanks for your contribution. This is now released to nuget as v1.18.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a swedish localization