Hebrew support #148
Hebrew support #148
Conversation
| [InlineData(-11, "לפני 11 יום")] | ||
| public void DaysAgo(int days, string expected) | ||
| { | ||
| Assert.Equal(expected, DateTime.UtcNow.AddDays(days).Humanize()); |
There was a problem hiding this comment.
SomeDate.Humanize is very hard to assert on as CPU ticks over during assertion and tests fail randomly. Please use the new DateHumanize.Verify method instead. You can see that used in other localisation tests.
There was a problem hiding this comment.
Yeah, I just took the Arabic tests and simply changed the strings, but I see your point. Using DateHumanize.Verify should then be used everywhere.
There was a problem hiding this comment.
It is almost used everywhere - a few classes still use the old Assert.Equal way. I think your code might have been based on the old Arabic tests as they were updated a few days ago.
There was a problem hiding this comment.
Bah, I must have missed it. Thanks, I'll fix it!
|
Thanks for the great contribution mate. I've commented on a few things I'd appreciate you could fix. Also please add your PR to the release_notes file on the root. |
|
Thanks for the notes, I'll fix all those things you mentioned! |
Fixed some grammatical Hebrew mistakes
|
Made more changes, fixing all your remarks! |
| src/TestResults/* | ||
| # Roslyn's metadata directory |
|
Thanks for the effort. This is merged now. Please implement For |
|
This is now published to NuGet as v1.21.1. Thanks. |
|
Woot! Awesome On Sat, Apr 12, 2014 at 5:48 PM, Mehdi Khalili notifications@github.comwrote:
Igal Tabachnik | Software Developer and Consultant | |
This PR adds support for humanizing Dates and TimeSpans into Hebrew. Based on the Arabic resource.